Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 3, 2025

What do these changes do?

Before, after deleting the file the current folder wouldn't stay selected, this PR fixes it.

Bonus:

Fixed glitch with the "Drop here" widget spotted while debugging with @giancarloromeo

SetFolderAfterDElete

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jan 3, 2025
@odeimaiz odeimaiz added this to the Event Horizon milestone Jan 3, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Jan 3, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 3, 2025 15:17
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

THOUGHT/QUESTION: does it make sense to consider trash for data as well?

@odeimaiz
Copy link
Member Author

odeimaiz commented Jan 5, 2025

thx

THOUGHT/QUESTION: does it make sense to consider trash for data as well?

Ufff... I guess it would be very hard to implement, but it would make sense from the user's perspective

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

@odeimaiz odeimaiz merged commit 208de24 into ITISFoundation:master Jan 7, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setFolder after deleting file from Service data

7 participants